Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a spike that clicks in a center of the nonoverlapped area of the action target element instead of the element's center #7309

Closed
AndreyBelym opened this issue Sep 28, 2022 · 1 comment · Fixed by #7330
Closed

Make a spike that clicks in a center of the nonoverlapped area of the action target element instead of the element's center #7309

AndreyBelym opened this issue Sep 28, 2022 · 1 comment · Fixed by #7330
Assignees
@Aleksey28

Comments

@AndreyBelym
Copy link
Contributor

No description provided.

@AndreyBelym AndreyBelym changed the title Make a spike that click in a center of the nonoverlapped area of the action target element instead of the element's center Make a spike that clicks in a center of the nonoverlapped area of the action target element instead of the element's center Sep 28, 2022
@Aleksey28 Aleksey28 mentioned this issue Oct 13, 2022
Merged
2 tasks
AndreyBelym pushed a commit that referenced this issue Nov 2, 2022
@Aleksey28
feat: upgraded click mechanism on element if offset options isn't set…
f79980f 
… and center isn't available (#7330)

<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

[closes #7309]

## Purpose
Click on the available point of the element.

## Approach
1. Research ways to find uncovered and visible points of the element
2. Add tests
3. Add a searching available point of the element if the element is
partly covered or hidden
4. Replace the default click offset with available

## References
#7309

## Pre-Merge TODO
- [X] Write tests for your proposed changes
- [x] Make sure that existing tests do not fail
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Release v2.1.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aleksey28 Aleksey28

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndreyBelym @Aleksey28