Add warnings for missing await when trying to get a snapshot property value #5383
+93
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
❌ Tests for the commit 601297d have failed. See details: |
|
❌ Tests for the commit 601297d have failed. See details: |
|
✅ Tests for the commit 601297d have passed. See details: |
|
❌ Tests for the commit 39f0bdb have failed. See details: |
AndreyBelym
approved these changes
Aug 17, 2020
AndreyBelym
changed the title
Ogurecher
force-pushed
the
missing-await-warning
branch
from
39f0bdb to
14b0594
Compare
|
❌ Tests for the commit 14b0594 have failed. See details: |
2 similar comments
|
❌ Tests for the commit 14b0594 have failed. See details: |
|
❌ Tests for the commit 14b0594 have failed. See details: |
|
✅ Tests for the commit 14b0594 have passed. See details: |
AlexKamaev
approved these changes
Aug 18, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a warning message when trying to get a snapshot property value without calling await (which returns a Promise).
Approach
Saving a callsite when accessing the snapshot property, deleting the callsite in
.then(if the property is awaited). If there are callsites left after the test finishes, printing a warningReferences
Part of #5087
Pre-Merge TODO