Skip to content

Configure request timeouts (close #2940) #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2020
Merged

Configure request timeouts (close #2940) #5692

merged 3 commits into from
Dec 21, 2020

Conversation

miherlosev
Copy link
Collaborator

@miherlosev miherlosev commented Nov 10, 2020 •
edited
Loading

Changes:

  • add pageRequestTimeout, ajaxRequestTimeout options
  • rewrite src/test-run/client-messages.js and src/test-run/phase.ts files to TypeScript

Related PR in hammerhead.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 6cb45ea have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit f816c65 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ca967f8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit ca967f8 have passed. See details:

@miherlosev miherlosev marked this pull request as ready for review November 11, 2020 11:46
AlexKamaev
AlexKamaev requested changes Nov 16, 2020
View reviewed changes
test/functional/fixtures/multiple-windows/test.js Outdated
it('Click on link', () => {
return runTests('testcafe-fixtures/switching-to-child/click-on-link.js');
});
if (config.useLocalBrowsers && !config.useHeadlessBrowsers) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the !config.useHeadlessBrowsers condition. However, if we remove the separate multiple-windows task we will have only the test-functional-local-headless-chrome. Thus, these tests will be ignored

@miherlosev miherlosev force-pushed the configure_request_timeouts branch 2 times, most recently from 613ee90 to 74b957f Compare November 20, 2020 06:28
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 794488b have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 794488b have failed. See details:

1 similar comment
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 794488b have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 794488b have passed. See details:

@miherlosev
Copy link
Collaborator Author

FPR

VasilyStrelyaev
VasilyStrelyaev reviewed Dec 11, 2020
View reviewed changes
src/cli/argument-parser.ts Outdated
@@ -131,6 +133,8 @@ export default class CLIArgumentParser {
.option('--selector-timeout <ms>', 'specify the time within which selectors make attempts to obtain a node to be returned')
.option('--assertion-timeout <ms>', 'specify the time within which assertion should pass')
.option('--page-load-timeout <ms>', 'specify the time within which TestCafe waits for the `window.load` event to fire on page load before proceeding to the next test action')
.option('--page-request-timeout <ms>', 'specify the time within which page request should be completed')
.option('--ajax-request-timeout <ms>', 'specify the time within which ajax request (xhr or fetch) should be completed')
Copy link
Collaborator

@VasilyStrelyaev VasilyStrelyaev Dec 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

            .option('--page-request-timeout <ms>', 'specify the time within which the request for page's HTML should be completed')
            .option('--ajax-request-timeout <ms>', 'specify the time within which AJAX requests (XHR or fetch) should be completed')

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although... We should wait for Dirk...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Dirk:

            .option('--page-request-timeout <ms>', 'specifies the timeout in milliseconds to complete the request for the page's HTML')
            .option('--ajax-request-timeout <ms>', 'specifies the timeout in milliseconds to complete the AJAX requests (XHR or fetch)')

VasilyStrelyaev
VasilyStrelyaev requested changes Dec 14, 2020
View reviewed changes
src/cli/argument-parser.ts Outdated
@@ -131,6 +133,8 @@ export default class CLIArgumentParser {
.option('--selector-timeout <ms>', 'specify the time within which selectors make attempts to obtain a node to be returned')
.option('--assertion-timeout <ms>', 'specify the time within which assertion should pass')
.option('--page-load-timeout <ms>', 'specify the time within which TestCafe waits for the `window.load` event to fire on page load before proceeding to the next test action')
.option('--page-request-timeout <ms>', 'specify the time within which page request should be completed')
.option('--ajax-request-timeout <ms>', 'specify the time within which ajax request (xhr or fetch) should be completed')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Dirk:

            .option('--page-request-timeout <ms>', 'specifies the timeout in milliseconds to complete the request for the page's HTML')
            .option('--ajax-request-timeout <ms>', 'specifies the timeout in milliseconds to complete the AJAX requests (XHR or fetch)')

@miherlosev miherlosev force-pushed the configure_request_timeouts branch from d73c793 to f780b94 Compare December 17, 2020 05:34
@miherlosev miherlosev force-pushed the configure_request_timeouts branch from f780b94 to 7313dc9 Compare December 17, 2020 05:36
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 7313dc9 have failed. See details:

1 similar comment
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 7313dc9 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit a1c51ca have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit a1c51ca have failed. See details:

@miherlosev miherlosev mentioned this pull request Dec 18, 2020
Merged
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

4 similar comments
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit c40cef8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit c40cef8 have passed. See details:

@miherlosev miherlosev merged commit 4d325db into DevExpress:master Dec 21, 2020
@miherlosev miherlosev mentioned this pull request Dec 21, 2020
Closed
@miherlosev miherlosev deleted the configure_request_timeouts branch December 23, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKamaev AlexKamaev

@AndreyBelym AndreyBelym

@VasilyStrelyaev VasilyStrelyaev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miherlosev @testcafe-build-bot @AlexKamaev @AndreyBelym @VasilyStrelyaev