Fix missing dependencies #5872
Merged
Fix missing dependencies #5872
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@babel/plugin-transform-for-of and @babel/runtime are required but not explicitly listed as dependencies. This prevents installing testcafe with Yarn 2, which is more strict.
need-response-app
bot
added
the
STATE: Need response
3 tasks
|
✅ Tests for the commit 1379bed have passed. See details: |
|
In case the issue isn’t clear, do this in a new directory:
|
|
Thank you for your contribution. |
need-response-app
bot
removed
the
STATE: Need response
AndreyBelym
approved these changes
Jan 18, 2021
AlexSkorkin
added a commit
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path #6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies #5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue #5942
testcafe-build-bot
added a commit
to testcafe-build-bot/testcafe
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path DevExpress#6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies DevExpress#5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue DevExpress#5942
testcafe-build-bot
added a commit
to testcafe-build-bot/testcafe
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path DevExpress#6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies DevExpress#5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue DevExpress#5942
AndreyBelym
pushed a commit
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path #6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies #5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue #5942
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Testcafe can’t be installed as is with Yarn 2, because some dependencies are missing in package.json, even though they are required.
Approach
Add
@babel/plugin-transform-for-ofand@babel/runtimeto the list of dependencies.See also
DevExpress/testcafe-legacy-api#51