Fix typeText replacing issue (fix #5921) #5942
Merged
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
|
❌ Tests for the commit f519c1e have failed. See details: |
rueyaa332266
changed the title
|
❌ Tests for the commit 8af5c1d have failed. See details: |
AlexKamaev
approved these changes
Feb 10, 2021
miherlosev
approved these changes
Feb 11, 2021
|
Thank you for the contribution to the TestCafe. At present, we have an issue with Travis CI and I will reopen this PR to force Travis CI's task. We will merge your PR as soon as the tests become green. |
need-response-app
bot
removed
the
STATE: Need response
need-response-app
bot
added
STATE: Need response
need-response-app
bot
added
STATE: Need response
|
❌ Tests for the commit 8af5c1d have failed. See details: |
need-response-app
bot
added
STATE: Need response
|
All tests are green (except Travis) #5942 (comment) |
|
Thank you all for helping! |
need-response-app
bot
added
the
STATE: Need response
miherlosev
removed
the
STATE: Need response
AlexSkorkin
added a commit
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path #6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies #5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue #5942
testcafe-build-bot
added a commit
to testcafe-build-bot/testcafe
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path DevExpress#6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies DevExpress#5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue DevExpress#5942
testcafe-build-bot
added a commit
to testcafe-build-bot/testcafe
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path DevExpress#6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies DevExpress#5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue DevExpress#5942
AndreyBelym
pushed a commit
that referenced
this pull request
Apr 9, 2021
[Chris-Greaves](https://github.com/Chris-Greaves) Add ability to specify Testcafe Configuration Path #6035 [NiavlysB](https://github.com/NiavlysB) Fix missing dependencies #5872 [rueyaa332266](https://github.com/rueyaa332266) Fix typeText replacing issue #5942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the issue in tyepText that it doesn't replace the old value when the old value fits input maxlength.
Approach
Following the support from @AlexKamaev in #5921
By fixing if condition which compare the maxlength with element value.
References
#5921
Pre-Merge TODO