Skip to content

Add ability to specify Testcafe Configuration Path #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 17, 2021
Merged

Add ability to specify Testcafe Configuration Path #6035

merged 10 commits into from
Mar 17, 2021
+115 −10

Conversation

Chris-Greaves
Copy link
Contributor

@Chris-Greaves Chris-Greaves commented Mar 10, 2021 •
edited
Loading

Purpose

Add the ability to specify the Testcafe config to use, instead of the default .testcaferc.json file. This is very useful for Monorepos, Pipelines and QoL for developers.

Approach

I added this functionality by extending the object passed into the createTestCafe method and adding checks to ensure the addition doesn't cause a breaking change.

References

This is a solution to issue #3428

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

Sorry, something went wrong.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 10, 2021
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4ab20de have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 5e5d4ca have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 1c782ee have failed. See details:

@Chris-Greaves Chris-Greaves marked this pull request as ready for review March 10, 2021 22:40
miherlosev
miherlosev requested changes Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@miherlosev miherlosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to the TestCafe. In general, your PR is great. I left some comments related to code style and formatting.

@miherlosev miherlosev removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 11, 2021
@Chris-Greaves
Copy link
Contributor Author

Chris-Greaves commented Mar 11, 2021 •
edited
Loading

@miherlosev Will look at making these changes this evening ready for tomorrow. Also need to update the docs so will do that too.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 11, 2021
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit dc13f01 have failed. See details:

@Chris-Greaves
Copy link
Contributor Author

@miherlosev Your comments should be resolved now, and the docs have been updated to include the new functionality. Any problems let me know.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 195fbb2 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit b3ce812 have failed. See details:

@Chris-Greaves
Copy link
Contributor Author

Chris-Greaves commented Mar 11, 2021 •
edited
Loading

Looks like the "continuous-integration-azure-mobile" check failed due to it taking too long, I'm guessing I can leave that to you to re-run or whatever?

@miherlosev miherlosev requested a review from DIRECTcut March 12, 2021 06:10
@miherlosev
Copy link
Collaborator

miherlosev commented Mar 12, 2021 •
edited
Loading

#6035

Looks like the "continuous-integration-azure-mobile" check failed due to it taking too long, I'm guessing I can leave that to you to re-run or whatever?

Yes, we will rerun this task.

@DIRECTcut check please documentation and CLI description

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 12, 2021
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit aec0bf2 have failed. See details:

@DIRECTcut
Copy link
Contributor

@Chris-Greaves

Hello and thank you for this awesome PR!

As our contribution guidelines suggest, documentation for new features should be committed to the new-docs branch. This is necessary to keep our website ready to publish at all times.

Please transfer all documentation changes to a new branch and open a pull request from there.
When the new PR is ready, feel free to request a review from me. Please open the branch for commits (I may need to commit some edits).

Thanks.

@Chris-Greaves Chris-Greaves mentioned this pull request Mar 16, 2021
Merged
2 tasks
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 16, 2021
@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 08bea91 have passed. See details:

@miherlosev miherlosev removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 17, 2021
@miherlosev @DIRECTcut
Update src/cli/argument-parser.ts
679989b 
Co-authored-by: Sergey Afonchenko <49588154+DIRECTcut@users.noreply.github.com>
@miherlosev miherlosev closed this Mar 17, 2021
@miherlosev miherlosev reopened this Mar 17, 2021
@need-response-app need-response-app bot added STATE: Need response An issue that requires a response or attention from the team. and removed STATE: Need response An issue that requires a response or attention from the team. labels Mar 17, 2021
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 679989b have failed. See details:

@miherlosev miherlosev closed this Mar 17, 2021
@miherlosev miherlosev reopened this Mar 17, 2021
@need-response-app need-response-app bot added STATE: Need response An issue that requires a response or attention from the team. and removed STATE: Need response An issue that requires a response or attention from the team. labels Mar 17, 2021
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 679989b have failed. See details:

@Chris-Greaves
Copy link
Contributor Author

@miherlosev I noticed that my branch is something like 13 commits behind master, did you need me to rebase the changes or anything?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 17, 2021
@miherlosev
Copy link
Collaborator

miherlosev commented Mar 17, 2021 •
edited
Loading

All tests are green

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 17, 2021
@miherlosev miherlosev merged commit 57aa1d3 into DevExpress:master Mar 17, 2021
@miherlosev
Copy link
Collaborator

The feature will be shipped with the next TestCafe version. We are going to release it in a few days.

@Chris-Greaves Chris-Greaves mentioned this pull request Mar 17, 2021
Closed
AlexSkorkin added a commit that referenced this pull request Apr 9, 2021
@AlexSkorkin
[docs] Add new contributors to the main page
b869021 
[Chris-Greaves](https://github.com/Chris-Greaves)

Add ability to specify Testcafe Configuration Path
#6035

[NiavlysB](https://github.com/NiavlysB)

Fix missing dependencies
#5872

[rueyaa332266](https://github.com/rueyaa332266)

Fix typeText replacing issue
#5942
@AlexSkorkin AlexSkorkin mentioned this pull request Apr 9, 2021
Merged
testcafe-build-bot added a commit to testcafe-build-bot/testcafe that referenced this pull request Apr 9, 2021
@testcafe-build-bot
[docs] Add new contributors to the main page
e54879f 
[Chris-Greaves](https://github.com/Chris-Greaves)

Add ability to specify Testcafe Configuration Path
DevExpress#6035

[NiavlysB](https://github.com/NiavlysB)

Fix missing dependencies
DevExpress#5872

[rueyaa332266](https://github.com/rueyaa332266)

Fix typeText replacing issue
DevExpress#5942
testcafe-build-bot added a commit to testcafe-build-bot/testcafe that referenced this pull request Apr 9, 2021
@testcafe-build-bot
[docs] Add new contributors to the main page
3bd46d0 
[Chris-Greaves](https://github.com/Chris-Greaves)

Add ability to specify Testcafe Configuration Path
DevExpress#6035

[NiavlysB](https://github.com/NiavlysB)

Fix missing dependencies
DevExpress#5872

[rueyaa332266](https://github.com/rueyaa332266)

Fix typeText replacing issue
DevExpress#5942
AndreyBelym pushed a commit that referenced this pull request Apr 9, 2021
@AlexSkorkin
[docs] docs: add new contributors to the main page (#6128)
fcbb987 
[Chris-Greaves](https://github.com/Chris-Greaves)

Add ability to specify Testcafe Configuration Path
#6035

[NiavlysB](https://github.com/NiavlysB)

Fix missing dependencies
#5872

[rueyaa332266](https://github.com/rueyaa332266)

Fix typeText replacing issue
#5942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miherlosev miherlosev

@DIRECTcut DIRECTcut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Chris-Greaves @testcafe-build-bot @miherlosev @DIRECTcut @ThomChrisG @wentwrong