Skip to content

feat: added sending error if concurrency isn't default and cdpPort isn't undefined #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jun 18, 2021
Merged

feat: added sending error if concurrency isn't default and cdpPort isn't undefined #6268

merged 31 commits into from
Jun 18, 2021
+409 −360

Conversation

Aleksey28
Copy link
Collaborator

[closes #6244]

Purpose

Send error if concurrency isn't default and cdpPort isn't undefined

Approach

  1. Move creating browsers config in initializing test-cafe config
  2. Move validation for browsers config runner
  3. Add test for this case

References

#6244

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

Sorry, something went wrong.

@Aleksey28 Aleksey28 temporarily deployed to CI May 31, 2021 14:50 Inactive
@Aleksey28 Aleksey28 marked this pull request as draft May 31, 2021 14:50
@Aleksey28 Aleksey28 temporarily deployed to CI June 1, 2021 07:05 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 1, 2021 08:30 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 2, 2021 07:18 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 08:53 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 09:08 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 09:48 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 11:18 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 11:31 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 11:43 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 11:54 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 12:07 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 12:28 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 14:50 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 3, 2021 15:20 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 4, 2021 06:14 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 4, 2021 06:20 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 4, 2021 07:12 Inactive
Aleksey28 added 24 commits June 18, 2021 10:01
@Aleksey28
feat: moved validation browser to runner from bootstrapper

Verified

This commit was signed with the committer’s verified signature. The key has expired.
alexandre-abrioux Alexandre ABRIOUX
GPG key ID: 5C4778F91CA5BB29
Expired
Verified
Learn about vigilant mode
92b7d08
@Aleksey28
test: fixed according to the feature

Verified

This commit was signed with the committer’s verified signature. The key has expired.
alexandre-abrioux Alexandre ABRIOUX
GPG key ID: 5C4778F91CA5BB29
Expired
Verified
Learn about vigilant mode
1263401
@Aleksey28
test: moved browsers tests on lunix to runner-test.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
429dd61
@Aleksey28
style: eslint fix
0d514f7
@Aleksey28
test: added test for raising error if concurrency more than 1 and cdp…
a649e8b 
… port isn't undefined
@Aleksey28
fix: added condition before getting cdpPort
a528b9c
@Aleksey28
feat: added initializing config in test-runner.js
4f1e2cf
@Aleksey28
refactor: deleted NOTE
a89fdba
@Aleksey28
fix: resolved conflict
945f6ef
@Aleksey28
refactor: reorganized options setting in configuration with runner api
3213d63
@Aleksey28
test: fixed tests
d7e9eda
@Aleksey28
test: fixed tests 2
5c92326
@Aleksey28
test: fixed tests 3
1011416
@Aleksey28
fix: changed checking property alias to browserOption
7ec2960
@Aleksey28
fix: changed condition for getting browser info
51018ad
@Aleksey28
fix: fixed with eslint
142ce79
@Aleksey28
fix: removed condition from _getBrowserInfo for getting browser info …
452d609 
…from provider
@Aleksey28
fix: changed validators sequence
17c8d84
@Aleksey28
fix: changed getting config
7f449c3
@Aleksey28
test: changed test result
e1dfd68
@Aleksey28
style: made alignment
2ebbcfb
@Aleksey28
refactor: simplified code
42be1cc
@Aleksey28
fix: added more flexible condition for alias
eef2815
@Aleksey28
fix: changed condition
fe95224
@Aleksey28 Aleksey28 temporarily deployed to CI June 18, 2021 07:02 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI June 18, 2021 07:35 Inactive
@Aleksey28 Aleksey28 merged commit b761012 into DevExpress:master Jun 18, 2021
@Aleksey28 Aleksey28 deleted the gh6244 branch December 2, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKamaev AlexKamaev

@AndreyBelym AndreyBelym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrent tests do not respect device
3 participants
@Aleksey28 @AlexKamaev @AndreyBelym