Skip to content

Address #6624, adding 'new' keyword to page-unload-barrier Promise #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rob4629
Copy link
Contributor

@rob4629 rob4629 commented Nov 23, 2021

Purpose

Describe the problem you want to address or the feature you want to implement.
Address #6624, where exception is thrown as detailed by @danieltroger here.

Approach

Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
Add new keyword to Promise creation, for waitForFileDownload in page-unload-barrier.ts

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

Sorry, something went wrong.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Nov 23, 2021
@rob4629 rob4629 temporarily deployed to CI November 23, 2021 21:45 Inactive
@Farfurix Farfurix added the STATE: PR Review Pending A note that this PR will be reviewed. label Nov 24, 2021
@Farfurix
Copy link
Contributor

@rob4629

Thank you for your contribution to TestCafe. We will review this PR.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Nov 24, 2021
@Farfurix Farfurix removed the STATE: PR Review Pending A note that this PR will be reviewed. label Nov 24, 2021
@rob4629
Copy link
Contributor Author

rob4629 commented Nov 24, 2021

I didn't add any new tests, as I felt this change would be covered by test/client/fixtures/core/page-unload-barrier.js

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Nov 24, 2021
@rob4629 rob4629 changed the title Address #6624, adding new keyword to page-unload-barrier Promise Address #6624, adding 'new' keyword to page-unload-barrier Promise Nov 24, 2021
@miherlosev miherlosev removed the STATE: Need response An issue that requires a response or attention from the team. label Dec 1, 2021
@miherlosev
Copy link
Collaborator

Check it in context of #6736

@rob4629 rob4629 temporarily deployed to CI December 6, 2021 21:03 Inactive
@rob4629
Copy link
Contributor Author

rob4629 commented Dec 6, 2021

Check it in context of #6736

👋🏻 @miherlosev, was this comment for me? I've tried updating the Safari version in test/function/config.js but not really sure what Safari tests need to be updated.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Dec 6, 2021
@miherlosev
Copy link
Collaborator

Hi @rob4629,

It was a comment for the team members. We can merge this PR and release a new alpha version if you need a version with the fix faster.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Dec 8, 2021
@rob4629
Copy link
Contributor Author

rob4629 commented Dec 8, 2021

Thanks for the offer. I'm good to wait until the next planned release

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Dec 8, 2021
@danieltroger
Copy link

Same, the yarn patch I made still works 👍

@miherlosev miherlosev removed the STATE: Need response An issue that requires a response or attention from the team. label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants