-
Notifications
You must be signed in to change notification settings - Fork 676
Address #6624, adding 'new' keyword to page-unload-barrier Promise #6719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address #6624, adding 'new' keyword to page-unload-barrier Promise #6719
Conversation
Thank you for your contribution to TestCafe. We will review this PR. |
I didn't add any new tests, as I felt this change would be covered by |
Check it in context of #6736 |
👋🏻 @miherlosev, was this comment for me? I've tried updating the Safari version in |
Hi @rob4629, It was a comment for the team members. We can merge this PR and release a new alpha version if you need a version with the fix faster. |
Thanks for the offer. I'm good to wait until the next planned release |
Same, the yarn patch I made still works 👍 |
Purpose
Describe the problem you want to address or the feature you want to implement.
Address #6624, where exception is thrown as detailed by @danieltroger here.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
Add
new
keyword to Promise creation, forwaitForFileDownload
in page-unload-barrier.tsReferences
Provide a link to the existing issue(s), if any.
Pre-Merge TODO