Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed incorrect Page URL visited when running tests in parallel in one file with Role #6782

Merged
merged 10 commits into from Dec 27, 2021
Merged

fix: fixed incorrect Page URL visited when running tests in parallel in one file with Role #6782

merged 10 commits into from Dec 27, 2021

Conversation

Aleksey28
Copy link
Collaborator

@Aleksey28 Aleksey28 commented Dec 20, 2021 •
edited

[closes #6041]

Purpose

Fix the incorrect URL of the page visited when running tests in parallel in the same file with the role.
This is because right now one role can only store one redirectUrl. And when we use one role in two and more tests with concurrency mode redirectUrl is rewritten in one test before the redirect occurs in another one.

Approach

  1. Add the tests to fix
  2. Add keeping redirect URL in the Role for each test

References

#6041

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI December 20, 2021 11:18 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 20, 2021 11:35 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 20, 2021 13:26 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 21, 2021 14:37 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 21, 2021 20:06 Inactive
AlexKamaev
AlexKamaev reviewed Dec 22, 2021
View reviewed changes
src/role/role.ts Outdated Show resolved Hide resolved
miherlosev
miherlosev requested changes Dec 22, 2021
View reviewed changes
src/test-run/bookmark.ts Outdated Show resolved Hide resolved
test/functional/fixtures/concurrency/test.js Outdated Show resolved Hide resolved
@Aleksey28 Aleksey28 temporarily deployed to CI December 22, 2021 12:14 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 22, 2021 14:45 Inactive
@Aleksey28 Aleksey28 self-assigned this Dec 23, 2021
@miherlosev miherlosev merged commit 6de1ed7 into DevExpress:master Dec 27, 2021
@Aleksey28 Aleksey28 deleted the gh6041 branch October 11, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKamaev AlexKamaev AlexKamaev approved these changes

@miherlosev miherlosev miherlosev approved these changes

Assignees

@Aleksey28 Aleksey28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Page URL visited when running tests in parallel in one file
3 participants
@Aleksey28 @AlexKamaev @miherlosev