fix: avoid browser hanging on close window while video is recording (closes #6037) #6800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miherlosev
requested changes
Jan 18, 2022
| @@ -184,6 +186,15 @@ export default class BrowserConnectionGateway { | |||
| } | |||
| } | |||
|
|
|||
| private static _onCloseWindowRequest (req: IncomingMessage, res: ServerResponse, connection: BrowserConnection): void { | |||
| if (BrowserConnectionGateway._ensureConnectionReady(res, connection)) { | |||
| connection.provider.closeBrowserChildWindow(connection.id) | |||
There was a problem hiding this comment.
Should we catch errors of the connection.provider.closeBrowserChildWindow method here?
| await this.setClientInactive(); | ||
|
|
||
| // NOTE: delay browser window closing | ||
| await delay(100); |
There was a problem hiding this comment.
Can we use here a more stable way to check that window is closed?
src/browser/provider/plugin-host.js
Outdated
| @@ -153,4 +153,8 @@ export default class BrowserProviderPluginHost { | |||
| getConfig (value) { | |||
| return value; | |||
| } | |||
|
|
|||
| closeBrowserChildWindow (/*browserId*/) { | |||
There was a problem hiding this comment.
async closeBrowserChildWindow (/*browserId*/) {}
AndreyBelym
changed the title
|
/rebase |
AndreyBelym
approved these changes
Mar 22, 2022
|
/rebase |
AndreyBelym
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6037