Fix CVE-2021-23566 in nanoid before 3.1.31 #6826
Merged
+15
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
viktoria2506
added
the
STATE: PR Review Pending
|
Hi @pgorny Thank you for your contribution to TestCafe. Please rebase this PR to fix tests. |
need-response-app
bot
removed
the
STATE: Need response
miherlosev
approved these changes
Jan 24, 2022
miherlosev
removed
the
STATE: PR Review Pending
AndreyBelym
approved these changes
Jan 24, 2022
|
Looks like we have some compatibility problem with the new nanoid version, I'm trying to fix it ASAP |
|
I cannot reproduce it locally, BTW tests are passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, nanoid is affected by CVE-2021-23566, but testcafe pins nanoid@^1.0.1 and due to semver it means it will not update automatically. Whilst the issue is small for a testing solution, the issue does bubble up to all consuming projecs, tainiting them.
For this issue to be fully addressed the corresponding PR in testcafe-browser-toosl needs to also be merged, that project to be updated and testcafe dependency on it needs to be bumped up.