Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplified checking scrollability of the element (closes #6601) #6937

Merged
merged 3 commits into from Mar 30, 2022
Merged

fix: simplified checking scrollability of the element (closes #6601) #6937

merged 3 commits into from Mar 30, 2022

Conversation

Aleksey28
Copy link
Collaborator

@Aleksey28 Aleksey28 commented Mar 22, 2022 •
edited

[closes #6601]

Purpose

Fix problem with scrolling hidden elements in dynamic lists.

Approach

  1. Add the possibility to scroll in the element with attribute overflow and value hidden

References

#6601

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI March 22, 2022 11:37 Inactive
@Aleksey28 Aleksey28 marked this pull request as draft March 22, 2022 11:37
@AndreyBelym
Copy link
Contributor

\rebase

@AndreyBelym AndreyBelym temporarily deployed to CI March 25, 2022 08:44 Inactive
@AndreyBelym
Copy link
Contributor

I suspect that failures in TakeElementScreenshot tests can be related to the PR's changes, @Aleksey28 please take a look

@Aleksey28 Aleksey28 temporarily deployed to CI March 29, 2022 09:42 Inactive
@AndreyBelym AndreyBelym changed the title refactor: simplified checking scrollability of the element fix: simplified checking scrollability of the element Mar 29, 2022
@Aleksey28 Aleksey28 marked this pull request as ready for review March 29, 2022 12:30
@AndreyBelym AndreyBelym changed the title fix: simplified checking scrollability of the element fix: simplified checking scrollability of the element (closes #6601) Mar 30, 2022
AndreyBelym
AndreyBelym reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@AndreyBelym AndreyBelym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a test please?

@Aleksey28 Aleksey28 temporarily deployed to CI March 30, 2022 10:50 Inactive
@AndreyBelym AndreyBelym merged commit 30f53c0 into DevExpress:master Mar 30, 2022
@Aleksey28 Aleksey28 deleted the fix/scroll branch October 11, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The t.scrollIntoView method may cause the "element not visible" error
2 participants
@Aleksey28 @AndreyBelym