Fix: Invalid browser specified in configuration throws an error when valid browser is specified in CLI(closes #6618) #6993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… valid browser is specified in CLI(closes DevExpress#6618)
Artem-Babich
changed the title
AlexKamaev
reviewed
Apr 25, 2022
AlexKamaev
approved these changes
Apr 25, 2022
miherlosev
requested changes
Apr 25, 2022
miherlosev
approved these changes
Apr 25, 2022
|
Release v1.19.0-alpha.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Browsers specified via CLI should override the browsers specified in the config file. Currently, the error will be thrown If you specify an invalid browser in the config file, despite the fact that a valid browser is specified via CLI.
References
#6618