Updated moment.js to resolve https://snyk.io/vuln/SNYK-JS-MOMENT-2440688 #6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
miherlosev
added
the
STATE: PR Review Pending
|
Thank you for your contribution to TestCafe. We will review this PR. |
github-actions
bot
removed
STATE: Need response
AndreyBelym
approved these changes
Apr 25, 2022
|
Release v1.19.0-alpha.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves https://snyk.io/vuln/SNYK-JS-MOMENT-2440688
Approach
moment.js' latest updates resolve this issue
References
Provide a link to the existing issue(s), if any.
Pre-Merge TODO
Unable to fully verify that tests are still passing. I run TestCafe in a arm64 Linux VM under a M1 macbook and
chrome:headlessis not available for it.Other tests that run are still passing. Hoping a CI would pick up anything wrong.