fix: fixed start test before task starting finishes #7102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miherlosev
requested changes
Jun 22, 2022
src/runner/browser-job.ts
Outdated
| @@ -20,8 +20,10 @@ interface BrowserJobResultInfo { | |||
| data?: any; // eslint-disable-line @typescript-eslint/no-explicit-any | |||
| } | |||
|
|
|||
| enum StartStatus { none, starting, started } | |||
There was a problem hiding this comment.
enum BrowserJobStatus { initialized, starting, started }
src/runner/browser-job.ts
Outdated
| export default class BrowserJob extends AsyncEventEmitter { | ||
| private _started: boolean; | ||
| private _startStatus: StartStatus; |
AlexKamaev
approved these changes
Jun 22, 2022
miherlosev
approved these changes
Jun 22, 2022
|
Release v1.20.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[closes #7062]
Purpose
Don't run tests until a task starts running.
Approach
References
#7062
Pre-Merge TODO