fix: prevented waiting element in the second time if an error was raised in the first #7111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was raised in the first.
miherlosev
requested changes
Jun 29, 2022
| @@ -2,6 +2,23 @@ import { AutomationErrorCtor } from '../types'; | |||
| import { FnInfo, SelectorErrorCb } from '../../client/driver/command-executors/client-functions/types'; | |||
| import * as Errors from './index'; | |||
|
|
|||
| export function createInvisibleErrorCtor (elementName?: string): AutomationErrorCtor | string { | |||
There was a problem hiding this comment.
export function getInvisibleErrorCtorData
| }; | ||
| } | ||
|
|
||
| export function createNotFoundErrorCtor (elementName?: string): AutomationErrorCtor | string { |
There was a problem hiding this comment.
export function getNotFoundErrorCtorData
| @@ -69,8 +69,11 @@ function assertErrorMessage (fn, expectedErrMessage) { | |||
| expect(actualErr.message).eql(expectedErrMessage); | |||
| } | |||
|
|
|||
| function makeSelector (str, skipVisibilityCheck) { | |||
| const builder = new SelectorBuilder(str, { visibilityCheck: !skipVisibilityCheck }, { instantiation: 'Selector' }); | |||
| function makeSelector (str, skipVisibilityCheck, needError, separatedErrors) { | |||
There was a problem hiding this comment.
Add default values to boolean arguments.
| @@ -43,4 +44,20 @@ describe('[API] t.typeText()', function () { | |||
| expect(errs[0]).to.contains('> 19 | await t.typeText(NaN, \'a\');'); | |||
| }); | |||
| }); | |||
|
|
|||
| if (!config.proxyless) { | |||
| it('Should not get selector the second time if the error was raised in the first.', function () { | |||
There was a problem hiding this comment.
Should not execute selector twice for non-existing element due to "confidential" option (GH-6623)
| only: 'chrome', | ||
| }) | ||
| .catch(function (errs) { | ||
| expect(testReport.durationMs).lessThan(1100); |
There was a problem hiding this comment.
Increase the selectorTimeout value to make test more stable (this test sometimes failed on my machine).
| @@ -156,6 +156,7 @@ export default class SelectorBuilder extends ClientFunctionBuilder { | |||
| apiFnChain: this.options.apiFnChain, | |||
| visibilityCheck: !!this.options.visibilityCheck, | |||
| timeout: this.options.timeout, | |||
| separatedErrors: this.options.separatedErrors, | |||
There was a problem hiding this comment.
I propose another name for this option - strictError.
miherlosev
approved these changes
Jun 29, 2022
|
Release v1.20.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[closes #6623]
Purpose
Prevent executing selector twice when it isn't available for the
typeTextcommand.Approach
References
#6623
Pre-Merge TODO