fix: supported switching to iframes that are places in a Shadow Root #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miherlosev
requested changes
Jul 13, 2022
src/client/core/utils/dom.js
Outdated
| export function findIframeByWindow (iframeWindow) { | ||
| const iframes = []; | ||
|
|
||
| document.querySelectorAll('*').forEach(elem => { |
There was a problem hiding this comment.
You should use the native methods from the hammerhead.nativeMethods for querySelector, querySelectorAll functions.
Consider using the find method from hammerhead here.
| if (elem.tagName === 'IFRAME') | ||
| iframes.push(elem); | ||
|
|
||
| if (elem.shadowRoot) |
There was a problem hiding this comment.
Avoid using the the forEach method here. It can be overridden and it's not cross-browser code (we are still supporting IE).
| @@ -52,6 +52,21 @@ test('Click on element in a nested iframe', async t => { | |||
| expect(iframeBtnClickCount).eql(1); | |||
| }); | |||
|
|
|||
| test.page`http://localhost:3000/fixtures/api/es-next/iframe-switching/pages/shadow.html` | |||
| ('Click on an element in a shadow iframe and return to the main window', async t => { | |||
| await t | |||
There was a problem hiding this comment.
Add a test for the case with nested shadow roots with iframes:
- element
- shadowRoot
- iframe
- element
- shadowRoot
- iframe
- shadowRoot
- element
- iframe
- shadowRoot
miherlosev
approved these changes
Jul 13, 2022
AndreyBelym
approved these changes
Jul 20, 2022
|
Release v1.20.1-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[closes #3673]
Purpose
Support switching to Iframes that are places in a Shadow Root
Approach
driverIframein the DOM for instancesChildIframeDriverLinkReferences
#3673
Pre-Merge TODO