feat: also check for Podman to determine if running in container #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
miherlosev
approved these changes
Sep 27, 2022
miherlosev
previously requested changes
Sep 27, 2022
miherlosev
removed
the
STATE: Need response
AndreyBelym
force-pushed
the
podman-check
branch
from
1dd6d34
to
9bbbec8
Compare
AndreyBelym
approved these changes
Oct 24, 2022
|
Release v2.0.2-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To run Chrome in a container (run by Docker or Podman), some flags are added to the start command of Chrome.
Approach
The check for determining if running in a Docker container is replaced with a check to determine if running in a container, with either Docker or Podman
Pre-Merge TODO