Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(session): graceful disconnection support #336

Merged
merged 4 commits into from
Dec 14, 2023
Merged

feat(session): graceful disconnection support #336

merged 4 commits into from
Dec 14, 2023

Conversation

pacmancoder
Copy link
Contributor

@pacmancoder pacmancoder commented Dec 13, 2023 •
edited

This PR implements graceful disconnect support.

Closes #115

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Coverage Report 🤖 ⚙️

Past:
Total lines: 27030
Covered lines: 16388 (60.63%)

New:
Total lines: 27047
Covered lines: 16387 (60.59%)

Diff: -0.04%

[this comment will be updated automatically]

@pacmancoder pacmancoder marked this pull request as ready for review December 13, 2023 19:31
@pacmancoder pacmancoder changed the title [DRAFT] feat(session): Graceful disconnection support feat(session): Graceful disconnection support Dec 13, 2023
CBenoit
CBenoit approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left a few comments for improvements, but no major concern otherwise. I’ll approve and let you merge at your convenience 🙂

crates/ironrdp-pdu/src/mcs.rs Outdated Show resolved Hide resolved
crates/ironrdp-pdu/src/mcs.rs Outdated Show resolved Hide resolved
crates/ironrdp-session/src/active_stage.rs Outdated Show resolved Hide resolved
crates/ironrdp-session/src/active_stage.rs Outdated Show resolved Hide resolved
crates/ironrdp-web/src/session.rs Outdated Show resolved Hide resolved
crates/ironrdp-web/src/session.rs Outdated Show resolved Hide resolved
crates/ironrdp-web/src/session.rs Outdated Show resolved Hide resolved
crates/ironrdp-session/src/x224/mod.rs Outdated Show resolved Hide resolved
crates/ironrdp-session/src/x224/mod.rs Outdated Show resolved Hide resolved
crates/ironrdp-session/src/x224/mod.rs Outdated Show resolved Hide resolved
@CBenoit CBenoit changed the title feat(session): Graceful disconnection support feat(session): graceful disconnection support Dec 13, 2023
@CBenoit CBenoit enabled auto-merge (squash) December 14, 2023 15:31
@CBenoit CBenoit merged commit 056ec6a into master Dec 14, 2023
7 checks passed
@CBenoit CBenoit deleted the feat/graceful-disconnect branch December 14, 2023 15:36
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request Mar 25, 2024
Merged
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request Apr 8, 2024
Merged
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request Apr 22, 2024
Merged
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User-Initiated message: Shutdown Request
2 participants
@pacmancoder @CBenoit