New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GraphModel #67
Added GraphModel #67
Conversation
Generally lifted from OrigoDB: https://raw.githubusercontent.com/DevrexLabs/OrigoDB/dev/src/OrigoDB.Core/Modeling/GraphModel.cs Added tests including end-to-end smoke tests covering basic usage and proving journaling/replaying of graph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you. Not sure if anyone is using the graph but it's good to have at least as an example. I can merge as is or if you'd like to make the small changes mentioned in the comments, I will wait. And of course, please sign the CLA.
Hi Robert. Thanks for the positive feedback! I'll resolve these changes some point this week/weekend. Looks like CLA has approved me as a different user so let me straighten that out well and we'll be good to go. |
I've pushed the requested changes and double-checked I've signed the CLA but some reason the status is still showing as unsigned?! |
Odd that the CLA check is failing, let me dig into that before I merge the PR. We don't want to upset any lawyers :) |
There's a known issue when using different email addresses for commits and the GH account itself: with a possible resolution proposed: |
Had to do a bit of a dance with GitHub but all seems good now. |
Great, thanks for the contribution. If you'd like to have a go at some other bits let's have a chat on https://gitter.im/memstate/lobby |
Generally lifted from OrigoDB:
https://raw.githubusercontent.com/DevrexLabs/OrigoDB/dev/src/OrigoDB.Core/Modeling/GraphModel.cs
Added tests including end-to-end smoke tests covering basic usage and proving journaling/replaying of graph.
Aware this is an unsolicited PR so won't feel offended if not required or fits your roadmap!