Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GraphModel #67

Merged
merged 2 commits into from Sep 28, 2018
Merged

Added GraphModel #67

merged 2 commits into from Sep 28, 2018

Conversation

Simcon
Copy link
Contributor

@Simcon Simcon commented Sep 23, 2018

Generally lifted from OrigoDB:

https://raw.githubusercontent.com/DevrexLabs/OrigoDB/dev/src/OrigoDB.Core/Modeling/GraphModel.cs

Added tests including end-to-end smoke tests covering basic usage and proving journaling/replaying of graph.

Aware this is an unsolicited PR so won't feel offended if not required or fits your roadmap!

Generally lifted from OrigoDB:

https://raw.githubusercontent.com/DevrexLabs/OrigoDB/dev/src/OrigoDB.Core/Modeling/GraphModel.cs

Added tests including end-to-end smoke tests covering basic usage and proving journaling/replaying of graph.
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@rofr rofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you. Not sure if anyone is using the graph but it's good to have at least as an example. I can merge as is or if you'd like to make the small changes mentioned in the comments, I will wait. And of course, please sign the CLA.

src/Memstate.Core/Models/Graph/GraphModel.cs Outdated Show resolved Hide resolved
src/Memstate.Core/Models/Graph/GraphModel.cs Outdated Show resolved Hide resolved
@Simcon
Copy link
Contributor Author

Simcon commented Sep 25, 2018

Hi Robert. Thanks for the positive feedback! I'll resolve these changes some point this week/weekend. Looks like CLA has approved me as a different user so let me straighten that out well and we'll be good to go.

@Simcon
Copy link
Contributor Author

Simcon commented Sep 28, 2018

I've pushed the requested changes and double-checked I've signed the CLA but some reason the status is still showing as unsigned?!

@rofr
Copy link
Member

rofr commented Sep 28, 2018

Odd that the CLA check is failing, let me dig into that before I merge the PR. We don't want to upset any lawyers :)

@rofr
Copy link
Member

rofr commented Sep 28, 2018

There's a known issue when using different email addresses for commits and the GH account itself:
cla-assistant/cla-assistant#352 (comment)

with a possible resolution proposed:
https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user

@Simcon
Copy link
Contributor Author

Simcon commented Sep 28, 2018

Had to do a bit of a dance with GitHub but all seems good now.

@rofr
Copy link
Member

rofr commented Sep 28, 2018

Great, thanks for the contribution. If you'd like to have a go at some other bits let's have a chat on https://gitter.im/memstate/lobby

@rofr rofr merged commit 0b4aa0f into DevrexLabs:master Sep 28, 2018
@Simcon Simcon deleted the graphmodel branch October 26, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants