Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct eslint-errors #58

Closed
adnasa opened this issue Sep 16, 2016 · 2 comments
Closed

correct eslint-errors #58

adnasa opened this issue Sep 16, 2016 · 2 comments
Milestone

Comments

@adnasa
Copy link
Member

adnasa commented Sep 16, 2016

Icon.js
  49:11  error  'icon.type' PropType is defined but prop is never used    react/no-unused-prop-types
  50:11  error  'icon.path' PropType is defined but prop is never used    react/no-unused-prop-types
  51:13  error  'icon.letter' PropType is defined but prop is never used  react/no-unused-prop-types

ResultList.js
  54:10  error  'theme' PropType is defined but prop is never used          react/no-unused-prop-types
  55:12  error  'results' PropType is defined but prop is never used        react/no-unused-prop-types
  55:30  error  'results.*' PropType is defined but prop is never used      react/no-unused-prop-types
  56:18  error  'selectedIndex' PropType is defined but prop is never used  react/no-unused-prop-types
@vutran
Copy link
Member

vutran commented Sep 20, 2016

Indirect references causes lint errors. We would just need to reference the props directly.

Issue report here: jsx-eslint/eslint-plugin-react#833

@vutran vutran added this to the v0.5.0 milestone Sep 26, 2016
@vutran
Copy link
Member

vutran commented Sep 27, 2016

Merged #62

@vutran vutran closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants