Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct eslint errors #62

Merged
merged 2 commits into from Sep 26, 2016
Merged

correct eslint errors #62

merged 2 commits into from Sep 26, 2016

Conversation

vutran
Copy link
Member

@vutran vutran commented Sep 22, 2016

Addresses #58

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 73.611% when pulling 9f793eb on hotfix/correct-eslint-errors into aa7d747 on develop.

@adnasa
Copy link
Member

adnasa commented Sep 24, 2016

After pulling this locally and run npm i, I got even more errors which is confusing..

@vutran
Copy link
Member Author

vutran commented Sep 26, 2016

@adnasa What errors are you receiving? Do you have any local changes that may affect it?

@vutran vutran added this to the v0.5.0 milestone Sep 26, 2016
@adnasa
Copy link
Member

adnasa commented Sep 26, 2016

I got the following after running a clean install
https://gist.github.com/adnasa/0656a63101133d2e50a6075637e73ac4

@vutran
Copy link
Member Author

vutran commented Sep 26, 2016

Got to rebase due to changes

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 73.611% when pulling b068ef8 on hotfix/correct-eslint-errors into 75a0c9d on develop.

@adnasa
Copy link
Member

adnasa commented Sep 26, 2016

everything is perfect now (still not being able to sleep)

@adnasa adnasa merged commit 76f0384 into develop Sep 26, 2016
@adnasa adnasa deleted the hotfix/correct-eslint-errors branch September 26, 2016 23:13
@vutran vutran mentioned this pull request Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants