Dependabot/npm and yarn/acorn 7.1.1 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problems with ESLint, as described here: eslint/eslint#13050 (comment) The problematic dependency `mkdirp` published a new version that bumps `minimist` to a safe version.
|
See here, there is a workaround for this: I shall rebase this branch to incorporate that instead. |
wu-lee
force-pushed
the
dependabot/npm_and_yarn/acorn-7.1.1
branch
from
53552df
to
460c8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending work addressing an upstream vulnerability in a dependency of ESLint.
GHSA-7fhm-mqm4-2wp7
ESlint has not yet fixed this, but work seems in progress:
eslint/eslint#13050
This will need to be revisited when it is fixed. In the mean time, we don't need to worry too much. ESLint is just a static analysis tool for finding bugs or bad EcmaScript practices in sea-map, and not part of the actual functionality of sea-map. Therefore this is not really a problem for users of sea-map, only a potential issue for developers who run ESLint on the code.