chore: support type only import in custom linter

DimensionDev · Mar 24, 2020 · 2f72848 · 2f72848
1 parent 80f0c63
commit 2f72848
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 21 deletions.
diff --git a/public/firefoxFix.js b/public/firefoxFix.js
@@ -45,18 +45,18 @@
     const PatchThisOfDescriptorToGlobal = (desc, global) => {
         const { get, set, value } = desc
         if (get)
-            desc.get = function() {
+            desc.get = function () {
                 if (this === globalThis) return get.apply(window)
                 return get.apply(this)
             }
         if (set)
-            desc.set = function(val) {
+            desc.set = function (val) {
                 if (this === globalThis) return set.apply(global, val)
                 return set.apply(this, val)
             }
         if (value && typeof value === 'function') {
             const desc2 = Object.getOwnPropertyDescriptors(value)
-            desc.value = function(...args) {
+            desc.value = function (...args) {
                 if (new.target) return Reflect.construct(value, args, new.target)
                 return Reflect.apply(value, this === globalThis ? global : this, args)
             }

diff --git a/scripts/import-linter.ts b/scripts/import-linter.ts
@@ -24,7 +24,7 @@ if (diags) {
 }
 
 function getChecker(): (path: string) => string | null {
-    return x => {
+    return (x) => {
         if (x.includes('@material-ui')) {
             return `@material-ui appears in the import chain!
 To write a cross context file, use safeMUI() inside the function to import them conditionally.
@@ -55,6 +55,7 @@ function checkReferenceRecursive(
     for (const dependency of file.getImportDeclarations()) {
         let isTypeOnlyImport = true
 
+        if (dependency.compilerNode?.importClause.isTypeOnly) continue
         // We consider default import and ns import is not type only import
         if (dependency.getDefaultImport() || dependency.getNamespaceImport()) {
             isTypeOnlyImport = false
@@ -97,7 +98,7 @@ function checkReferenceRecursive(
         esModuleStyleImport.push(path)
     }
     const nodeStyleRequires: string[] = []
-    file.transform(traversal => {
+    file.transform((traversal) => {
         const node = traversal.visitChildren()
         // require('...')
         if (!ts.ts.isCallExpression(node)) return node
@@ -125,7 +126,7 @@ function checkReferenceRecursive(
         if (diag) {
             console.error(`${diag}
 Import chain:
-${nextRefChain.map(x => '  => ' + x).join('\n')}
+${nextRefChain.map((x) => '  => ' + x).join('\n')}
 `)
             hasDiagnostics = true
         }

diff --git a/scripts/jest-global-setup.js b/scripts/jest-global-setup.js
@@ -3,11 +3,11 @@ module.exports = async () => {
 }
 
 function addAsmCryptoForTest(cb) {
-    var download = function(url, dest, cb) {
+    var download = function (url, dest, cb) {
         var file = fs.createWriteStream(dest)
-        var request = http.get(url, function(response) {
+        var request = http.get(url, function (response) {
             response.pipe(file)
-            file.on('finish', function() {
+            file.on('finish', function () {
                 file.close(cb)
             })
         })

diff --git a/scripts/puppeteer-repl.js b/scripts/puppeteer-repl.js
@@ -30,7 +30,7 @@ const pptOpts = {
 function findChrome() {
     try {
         const clBase = path.join(require.resolve('chrome-launcher'), '..')
-        global.clInt = x => require(path.join(clBase, `${x}.js`))
+        global.clInt = (x) => require(path.join(clBase, `${x}.js`))
         return clInt('chrome-finder')[clInt('utils').getPlatform()]()[0]
     } catch (e) {
         console.error(e)

diff --git a/webpack.config.js b/webpack.config.js
@@ -7,7 +7,7 @@ const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin')
 const ForkTsCheckerNotifierWebpackPlugin = require('fork-ts-checker-notifier-webpack-plugin')
 const git = require('@nice-labs/git-rev').default
 
-const src = file => path.join(__dirname, file)
+const src = (file) => path.join(__dirname, file)
 /**
  * Polyfills that needs to be copied to dist
  */
@@ -36,21 +36,21 @@ const ManifestGeneratorPlugin = require('webpack-extension-manifest-plugin')
  * --wk-webview
  * --e2e
  */
-const calcTarget = argv => ({
+const calcTarget = (argv) => ({
     /** @type {'nightly' | boolean} */
-    Firefox: (argv.firefox || argv['firefox-android'] || argv['firefox-gecko']),
+    Firefox: argv.firefox || argv['firefox-android'] || argv['firefox-gecko'],
     /** @type {string | boolean} */
-    FirefoxDesktop: (argv.firefox),
+    FirefoxDesktop: argv.firefox,
     /** @type {boolean} */
-    FirefoxForAndroid: (argv['firefox-android']),
+    FirefoxForAndroid: argv['firefox-android'],
     /** @type {boolean} */
-    StandaloneGeckoView: (argv['firefox-gecko']),
+    StandaloneGeckoView: argv['firefox-gecko'],
     /** @type {boolean} */
-    Chromium: (argv.chromium),
+    Chromium: argv.chromium,
     /** @type {boolean} */
-    WKWebview: (argv['wk-webview']),
+    WKWebview: argv['wk-webview'],
     /** @type {boolean} */
-    E2E: (argv.e2e),
+    E2E: argv.e2e,
 })
 
 /**
@@ -61,7 +61,7 @@ module.exports = (argvEnv, argv) => {
     const target = calcTarget(argv)
 
     if (target.Firefox) {
-        polyfills = polyfills.filter(name => !name.includes('webextension-polyfill'))
+        polyfills = polyfills.filter((name) => !name.includes('webextension-polyfill'))
     }
     if (target.StandaloneGeckoView || target.WKWebview) polyfills.push(require.resolve('./src/polyfill/permissions.js'))
 
@@ -294,7 +294,7 @@ module.exports = (argvEnv, argv) => {
     if (!fs.existsSync(publicPolyfill)) {
         fs.mkdirSync(publicPolyfill)
     }
-    polyfills.map(x => void fs.copyFileSync(x, path.join(publicPolyfill, path.basename(x))))
+    polyfills.map((x) => void fs.copyFileSync(x, path.join(publicPolyfill, path.basename(x))))
 
     if (env !== 'development') {
         config.plugins.push(new SSRPlugin('popup.html', src('./src/extension/popup-page/index.tsx')))