Skip to content

Commit

Permalink
chore: fix unused import cause to runtime fail
Browse files Browse the repository at this point in the history
  • Loading branch information
Jack-Works committed Mar 25, 2020
1 parent 4ef72af commit d233170
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/extension/options-page/DashboardInitSteps/Step2S.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import ActionButton from '../DashboardComponents/ActionButton'
import useQueryParams from '../../../utils/hooks/useQueryParams'
import Services from '../../service'
import { ECKeyIdentifier, Identifier } from '../../../database/type'
import { Persona } from '../../../database'
import ProfileBox from '../DashboardComponents/ProfileBox'
import { useMyPersonas } from '../../../components/DataSource/useActivatedUI'
import { InitStep } from '../InitStep'
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
// "noUnusedParameters": true, /* Report errors on unused parameters. */
"noImplicitReturns": true /* Report error when not all code paths in function return a value. */,
"noFallthroughCasesInSwitch": true /* Report errors for fallthrough cases in switch statement. */,
// In webpack it will be turned to "remove".
"importsNotUsedAsValues": "error",

/* Module Resolution Options */
Expand Down
1 change: 1 addition & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ function addTSLoader() {
module: 'esnext',
jsx: 'react',
noEmit: false,
importsNotUsedAsValues: 'remove',
},
},
}
Expand Down

0 comments on commit d233170

Please sign in to comment.