Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query_raw method #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

diegocrzt
Copy link

Considering #75, what do you think of having a query_raw, almost the same as query, but after doing the request, and parsing json/xml return the raw string response from the server, but doing the validations for remark messages.

I am not sure if this is justified, I was using Overpy but really needed some transformations that requires the original response returned by OSM as base, so I ended up modifying overpy to do this.

Of course this could be improved but I wanted to know what you think about it.

Signed-off-by: Diego Ramírez <diegocrzt@gmail.com>
Signed-off-by: Diego Ramírez <diegocrzt@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-16.5%) to 78.184% when pulling 77d333a on diegocrzt:raw_query_result into 8aa4baf on DinoTools:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-16.5%) to 78.184% when pulling 77d333a on diegocrzt:raw_query_result into 8aa4baf on DinoTools:master.

@fakerms
Copy link

fakerms commented Sep 29, 2021

Will this pr be merged?

@devinmatte
Copy link

Something like this would be very helpful! I was really trying to get the json output it directly to disk and couldn't find a clean way to do it currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants