Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency com.discord4j:stores-api in /common module seems to be in the wrong scope. #1200

Closed
HappyHacker123 opened this issue Apr 8, 2024 · 0 comments · Fixed by #1201
Closed

Comments

@HappyHacker123
Copy link
Contributor

Expected Behavior: Some classes in com.discord4j:stores-api are exposed in the library binary interface. For example, class discord4j.store.api.service.StoreService in stores-api is used as public method parameter in class common/src/main/java/discord4j/common/store/legacy/LegacyStoreLayout.java. According to gradle official doc, stores-api should be set to scope api.

types used in public method parameters, including generic parameter types 

Actual Behavior: stores-api has scope implementation, this can lead to compilation failures in consumers, as mentioned in offical doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant