Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change scope of com.discord4j:stores-api from implementation to api. #1201

Merged
merged 1 commit into from
May 18, 2024
Merged

Change scope of com.discord4j:stores-api from implementation to api. #1201

merged 1 commit into from
May 18, 2024

Conversation

HappyHacker123
Copy link
Contributor

@HappyHacker123 HappyHacker123 commented Apr 8, 2024 •
edited

Description: Change scope of com.discord4j:stores-api from implementation to api.
Justification: Fix #1200 according to gradle official doc.

@HappyHacker123
Copy link
Contributor Author

@Azn9 @Doc94 Could you please take a look at this pr? Many thanks :)

@Azn9
Copy link
Member

Azn9 commented Apr 8, 2024

I'm already here 👻

@HappyHacker123
Copy link
Contributor Author

I'm already here 👻

Really appreciate your prompt response :)

Azn9
Azn9 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@Azn9 Azn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This don't seem to break neither the compilation nor the use of the lib. However, I'd like to have @quanticc 's opinion on this too (as he added this, maybe there's a reason for why "implementation" over "api").

@Azn9 Azn9 requested a review from quanticc April 8, 2024 03:32
quanticc
quanticc approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@quanticc quanticc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Regarding the reason, it's probably an oversight after moving Store to the common module, that didn't trigger anything since we use Stores in the context of core module only, where it is configured as api.

@Azn9 Azn9 added this to the 3.3.0 milestone Apr 14, 2024
@Doc94
Copy link
Member

Doc94 commented May 13, 2024

i dont check but this can target 3.2.x?

@Doc94 Doc94 changed the base branch from master to 3.2.x May 16, 2024 15:57
@Doc94 Doc94 changed the base branch from 3.2.x to master May 16, 2024 15:58
@Azn9
Copy link
Member

Azn9 commented May 18, 2024

i dont check but this can target 3.2.x?

Yeah it should, I'll rebase it

@Azn9 Azn9 changed the base branch from master to 3.2.x May 18, 2024 15:13
@Azn9 Azn9 merged commit e9ddfb4 into Discord4J:3.2.x May 18, 2024
4 checks passed
Azn9 added a commit that referenced this pull request May 18, 2024
@Azn9
Merge #1201 into 3.3.0
7475da1
@Doc94 Doc94 modified the milestones: 3.3.0, 3.2.7 May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanticc quanticc quanticc approved these changes

@Doc94 Doc94 Doc94 approved these changes

@Azn9 Azn9 Azn9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.7
Development

Successfully merging this pull request may close these issues.

Dependency com.discord4j:stores-api in /common module seems to be in the wrong scope.
4 participants
@HappyHacker123 @Azn9 @Doc94 @quanticc