Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the Guild#getFeatures return value to a FeatureSet instead of a Set<String> #1196

Closed
Azn9 opened this issue Mar 20, 2024 · 2 comments · Fixed by #1207
Closed

Replace the Guild#getFeatures return value to a FeatureSet instead of a Set<String> #1196

Azn9 opened this issue Mar 20, 2024 · 2 comments · Fixed by #1207
Labels
good first issue Good for newcomers

Comments

@Azn9
Copy link
Member

Azn9 commented Mar 20, 2024

Feature Description: It may be difficult to use the returned value of the getFeatures method as it returns a raw Set<String>, instead of something backed by an enum. By replacing this with something like the PermissionSet, it would help developers use this data more easily.
@Azn9 Azn9 added the good first issue Good for newcomers label Mar 20, 2024
@Doc94
Copy link
Member

Doc94 commented Mar 29, 2024

this is like a breaking change not?
can be good be added in the current release 3.2.x or most for 3.3?

@Azn9
Copy link
Member Author

Azn9 commented Apr 2, 2024

this is like a breaking change not? can be good be added in the current release 3.2.x or most for 3.3?

Yeah, that would be a breaking change. I think that the "getFeatures" method is not very used so it's a relatively small change. 3.2.x can benefit from it, so target 3.2.X for the branch

This was referenced May 7, 2024
Closed
Merged
@Doc94 Doc94 linked a pull request May 12, 2024 that will close this issue
feat(): replaced the Guild#getFeatures List<String> by an EnumSet<Fea… #1207
Merged
@Doc94 Doc94 closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(): replaced the Guild#getFeatures List<String> by an EnumSet<Fea… gmisiurny/Discord4J
2 participants
@Doc94 @Azn9