Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(): replaced the Guild#getFeatures List<String> by an EnumSet<Fea… #1207

Merged
merged 8 commits into from
May 16, 2024
Merged

feat(): replaced the Guild#getFeatures List<String> by an EnumSet<Fea… #1207

merged 8 commits into from
May 16, 2024

Conversation

gmisiurny
Copy link
Contributor

Description : #1196 (comment)

Justification : to help developers use this data more easily.

Doc94
Doc94 requested changes May 12, 2024
View reviewed changes
Copy link
Member

@Doc94 Doc94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the First PR i make a few comments about things for check...
i dont check but maybe this PR can consider allow use this enums in the editSpeec for enable/disable features.

core/src/main/java/discord4j/core/object/entity/Guild.java Show resolved Hide resolved
core/src/main/java/discord4j/core/object/entity/Guild.java Outdated Show resolved Hide resolved
core/src/main/java/discord4j/core/object/entity/Guild.java Outdated Show resolved Hide resolved
core/src/main/java/discord4j/core/object/entity/Guild.java Outdated Show resolved Hide resolved
@Doc94 Doc94 added enhancement Improvement over an existing feature area/core Related to core module: events, entities, clients, specs labels May 12, 2024
@Doc94 Doc94 linked an issue May 12, 2024 that may be closed by this pull request
Replace the Guild#getFeatures return value to a FeatureSet instead of a Set<String> #1196
Closed
@Doc94 Doc94 mentioned this pull request May 12, 2024
Closed
gmisiurny and others added 3 commits May 12, 2024 19:50
@gmisiurny @Doc94
Update core/src/main/java/discord4j/core/object/entity/Guild.java
a5de247 
Co-authored-by: Pedro <3602279+Doc94@users.noreply.github.com>
@gmisiurny @Doc94
Update core/src/main/java/discord4j/core/object/entity/Guild.java
76528b4 
Co-authored-by: Pedro <3602279+Doc94@users.noreply.github.com>
@gmisiurny
chore(): documentation update
bef751f
@Doc94 Doc94 added the API change Breaks public API in x.y releases, needs migration docs label May 12, 2024
@Doc94
Copy link
Member

Doc94 commented May 13, 2024

Maybe can be good replace the of method for pass the value and not a list like another methods for EnumSet
Apart of that i feel this is good.

@Azn9 Azn9 added deprecation An API deprecation is introduced in this issue and removed API change Breaks public API in x.y releases, needs migration docs labels May 13, 2024
@gmisiurny @Doc94
Update core/src/main/java/discord4j/core/object/entity/Guild.java
4d40633 
Co-authored-by: Pedro <3602279+Doc94@users.noreply.github.com>
@Doc94 Doc94 merged commit 3988353 into Discord4J:3.2.x May 16, 2024
4 checks passed
Doc94 added a commit that referenced this pull request May 16, 2024
@Doc94
Merge #1207 into 3.3.0
21c3457
@Doc94 Doc94 added this to the 3.2.7 milestone May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doc94 Doc94 Doc94 approved these changes

@Azn9 Azn9 Azn9 approved these changes

Assignees
No one assigned
Labels
area/core Related to core module: events, entities, clients, specs deprecation An API deprecation is introduced in this issue enhancement Improvement over an existing feature
Projects
None yet
Milestone
3.2.7
Development

Successfully merging this pull request may close these issues.

Replace the Guild#getFeatures return value to a FeatureSet instead of a Set<String>
3 participants
@gmisiurny @Doc94 @Azn9