Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BOM for Reactor and Member Logic Fixes #1180

Open
wants to merge 1 commit into
base: 3.2.x
Choose a base branch
from

Conversation

EasternGamer
Copy link

Description:

  • Updated Reactor BOM
  • Added .equal override for PartialMember.java to account for guild ID.
  • Made .equal override in User.java no longer final to enable override in PartialMember.java

Justification:

  • The current version used of Reactor has security vulnerabilities. (Though, I'm not sure why the version used it so old)
  • Comparing to members with .equals() can falsely state that two members that are the same user, but in different guilds are the same.
  • Impossible to make the above happen without removing the final modifier.

@Azn9 Azn9 added this to the 3.3.0 milestone Apr 14, 2024
@Azn9
Copy link
Member

Azn9 commented May 18, 2024

This should target 3.2.X, I'll rebase it

Added .equal override for PartialMember.java to account for guild ID.
Made .equal override in User.java no longer final to enable override in PartialMember.java
@Azn9 Azn9 changed the base branch from master to 3.2.x May 18, 2024 15:19
@Azn9 Azn9 requested a review from Doc94 May 18, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants