-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more Java LTS in GitHub Actions #1204
Open
Doc94
wants to merge
11
commits into
Discord4J:3.2.x
Choose a base branch
from
Doc94:feature/1203/support-check-java-21
base: 3.2.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix task core.sourcesJar throw error related order of run - Handle breaking change for source version
Doc94
commented
Apr 13, 2024
@@ -4,7 +4,8 @@ plugins { | |||
id 'signing' | |||
id 'com.gorylenko.gradle-git-properties' version '2.3.2' apply false | |||
id 'com.github.ben-manes.versions' version '0.38.0' | |||
id 'net.researchgate.release' version '2.8.1' | |||
// TODO: Warning for Gradle 9 by https://github.com/researchgate/gradle-release/issues/379 | |||
id 'net.researchgate.release' version '3.0.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note... this is currently the only thing throw a warning, this not affect the process but for Gradle 9 this going to break the release tasks... this was reported in researchgate/gradle-release#379 currently with not good responses (?
NovaFox161
requested review from
quanticc and
darichey
and removed request for
quanticc
April 15, 2024 18:06
Azn9
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1203
This also require update the gradle wrapper version.