Fix CVEs and update dependencies #1205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I currently have this published locally and am using it to build my first Discord4J bot |
|
Looks like this updates breaks the compile with Java 8 |
Strange. This compiles for me locally. I've been using it all day to transfer my old bot from JS to Kotlin. It should be fixable |
|
I'm using Coretto 1.8 |
Azn9
reviewed
May 5, 2024
|
This one should be fixed for all CVEs in logback |
|
However, lavaplayer still needs to be fixed upstream |
|
This should target 3.2.X, I'll rebase it |
Azn9
approved these changes
May 18, 2024
Doc94
requested changes
May 18, 2024
Comment on lines
+4
to
+5
| api "io.projectreactor.netty:reactor-netty-http:1.1.18" | ||
| api "io.projectreactor.addons:reactor-extra:3.5.1" |
There was a problem hiding this comment.
i feel this need to be moved to a var like the rest of version definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes CVE-2021-42550, CVE-2023-34462, CVE-2023-44487, and CVE-2023-34062. Does not fix, however, Cxeb68d52e-5509, CVE-2021-37714, CVE-2020-13956, and CVE-2021-29425. These other ones need to be fixed upstream in lavaplayer.
Justification: I don't feel comfortable nor should anyone, using Discord4J as long as it has CVEs. These CVEs might not affect Discord4J, but it is better to side with caution.
This version builds and tested using
./gradlew test.Additionally, old dependencies were updated because Discord4J uses 2-3 years old versions.