Version constraint match #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core dependencies require Elixir 1.4 and Elixir 1.5+. On Elixir 1.5 the application builds and tests pass. However for doc generation via `mix docs` Elixir 1.7+ is required due to the `ex_doc` dev dependency.
|
Based on the Travis build seems like this needs to be 1.5. Will update. |
|
@matt-glover I'll take a look at this in the next few days, DockYard is using this library internally and I'm not sure what version that app is on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking to build this locally I started by trying to run it with Elixir 1.3 based on the version constraint in
mix.exs.I ran into issues and through trial and error discovered that I need to be on Elixir 1.7+ to build and run all the key tasks for the application. The app appears to build, test, and generally run correctly with Elixir 1.5 with the exception of
mix docs.1.5 throws this error if you try for mix docs so conceivably a library downgrade could be attempted:
Edit: Based on the Travis CI results it seems like 1.5 support is expected so I selected that version to start with.
Also updated
mix.lockbecause the latest version of hex I pulled down includes the checksums for deps. Happy to move that into a separate PR if that's preferred.