Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency version requirement for httpoison to allow ~> 2.0 #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cgrothaus
Copy link

Goal

Allow using httpoison in version 2.0.

httpoison had a backwards compatible major release, going from 1.8 to 2.0. The current version requirement in mix.exs prevents this upgrade.

Changes

  • ⬆️ Upgrade version requirements for httpoison dependency to allow ~> 2.0
  • ⬆️ upgrade locked dependencies (via mix deps.get)

@AndrewDryga
Copy link
Collaborator

Thank you @cgrothaus!

@cgrothaus
Copy link
Author

@AndrewDryga 🆒 , thanks for reviewing and approving! Do you already have plans when this shall be merged and released as a new version?

@AndrewDryga
Copy link
Collaborator

@cgrothaus I should be fairly easy to push this as a new release but I'm a new maintainer here so need to make sure that we won't break anything and gain permission to push this hex package first.

FYI there is a high chance that the new major version would not have HTTPoison at all.

@bcardarella
Copy link
Member

As long as we are staying spec compliant with OpenID connect itself we should be OK for a release. One hasn't happened in a long time but we're implementing OpenID Connect on the new dockyard.com's admin so we should be able to integrate the release and provide quick feedback on any issues

@cgrothaus
Copy link
Author

@AndrewDryga Good to know that you are actively developing this package and that there is a new major version coming. I really appreciate this.

@bcardarella In the meantime (until a new major release) I would welcome a small maintenance release, that would be nice.

@cgrothaus
Copy link
Author

@AndrewDryga @bcardarella I see that the PR for the complete rewrite of the library #50 was merged several months ago. Are there any plans to release a new version to hex?

@bcardarella
Copy link
Member

bcardarella commented Nov 29, 2023

I've been meaning to address the state of this lib. With the EEF producing their own we may delegate to that. https://hex.pm/packages/oidcc I haven't used it so cannot vouch for its quality

@cgrothaus
Copy link
Author

Ah, thanks for clarifying, and for hinting to the EEF library 💡 . I hadn't heard of that before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants