Skip to content

Commit

Permalink
fix(core): declare cli as direct dependency
Browse files Browse the repository at this point in the history
Having `cli` as dependency of `workspace` was working because of the
flattened module structure that NPM/Yarn use. On stricter package
managers like PNPM and Yarn 2 this is not the case, and any `pnpm nx` or
`yarn nx` command was failing because `@nrwl/cli` couldn't be located.

ISSUES CLOSED: nrwl#2944
  • Loading branch information
bekos authored and Doginal committed Nov 25, 2020
1 parent 99c31e7 commit 05b2fba
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion packages/workspace/package.json
Expand Up @@ -68,7 +68,6 @@
"yargs": "15.4.1",
"yargs-parser": "20.0.0",
"chalk": "2.4.2",
"@nrwl/cli": "*",
"axios": "0.19.2",
"flat": "^5.0.2",
"minimatch": "3.0.4",
Expand Down
Expand Up @@ -41,6 +41,7 @@
"dependencies": {},
"devDependencies": {
<% if(cli === 'angular') { %>"@angular/cli": "<%= angularCliVersion %>",<% } %>
"@nrwl/cli": "<%= nxVersion %>",
"@nrwl/workspace": "<%= nxVersion %>",
"@types/node": "~8.9.4",
"dotenv": "6.2.0",
Expand Down

0 comments on commit 05b2fba

Please sign in to comment.