Correction of the accounting number for foreign customers / suppliers #29387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction numéro de compte comptable pour les lignes de factures liées aux clients hors pays d'origine (UE, Export)
Fixed accounting account number for supplier invoice lines outside the original country (EU, export) // Correction numéro de compte comptable pour les lignes de factures fournisseurs hors pays d'origine (UE, Export)
eldy
reviewed
Apr 18, 2024
| @@ -542,8 +543,10 @@ public function __construct($db) | |||
| 'fd.rowid'=>'LineId', 'fd.description'=>"LineDescription", | |||
| 'fd.subprice'=>"LineUnitPrice", 'fd.tva_tx'=>"LineVATRate", 'fd.qty'=>"LineQty", 'fd.total_ht'=>"LineTotalHT", 'fd.total_tva'=>"LineTotalVAT", | |||
| 'fd.total_ttc'=>"LineTotalTTC", 'fd.buy_price_ht'=>'BuyingPrice', 'fd.date_start'=>"DateStart", 'fd.date_end'=>"DateEnd", 'fd.special_code'=>'SpecialCode', | |||
| 'fd.product_type'=>"TypeOfLineServiceOrProduct", 'fd.fk_product'=>'ProductId', 'p.ref'=>'ProductRef', 'p.label'=>'ProductLabel', | |||
| $alias_product_perentity . '.accountancy_code_sell'=>'ProductAccountancySellCode', | |||
There was a problem hiding this comment.
Why removing this information from export ?
Some use cases need it.
eldy
added
the
Discussion
eldy
added
the
PR to fix or conflict to solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
These changes correct accounting numbers for exporting customer and suppliers invoices.
We take the accounting number of the invoice line and not the product.