FIX : Default action type code when send mail. #29527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Apr 29, 2024
| @@ -382,7 +382,7 @@ | |||
| // Initialisation of datas of object to call trigger | |||
| if (is_object($object)) { | |||
| if (empty($actiontypecode)) { | |||
| $actiontypecode = 'AC_OTH_AUTO'; // Event insert into agenda automatically | |||
| $actiontypecode = 'AC_EMAIL'; // Event insert into agenda automatically | |||
There was a problem hiding this comment.
There is 2 types of events:
Event enter manually by the user into the agenda.
Events created automatically by the system for tracking purposes.
An email send from a screen is the second one. So it must not appears into the agenda of the user among its rendez vous but into the agenda of tracking events. So $actiontypecode (the type auto / non auto) must be 'AC_OTH_AUTO' (instead of AC_OTH). All other codes inside llx_c_actioncomm are deprecated.
Note that there is a column "code" into the table llx_actioncomm that is what king of action has been recorded. You can know it is an email with this code, because emails are codes like 'AC_..._SENTBYMAIL' into this table.
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX|Fix Default action type code when send mail. Changed from AC_OTH_AUTO to AC_EMAIL
By default, the action type code when you send an email is AC_OTH_AUTO. I think it is more relevant to set it to AC_EMAIL.