Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19.0 fix search all hidden input #29557

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

samifilali
Copy link
Contributor

FIX

The filters applied during the global search are retained even after loading the corresponding object list (example: tier, customer order, etc.)

This poses a problem when you want to apply a new filter on the list (coming from the global search) => the global search filter is kept and cannot be deleted without refresh the page

Can this code be deleted ?

@eldy
Copy link
Member

eldy commented May 1, 2024

What do you mean with "The filters applied during the global search are retained even after loading the corresponding object list " ? Can you provide a screenshot and a process to reproduce ?

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label May 1, 2024
@samifilali
Copy link
Contributor Author

When I perform a global search in third parties (1st screenshot), I obtain 7 results (2nd screenshot). However, when I perform a new search in the list, the 'test' filter that I had entered for my global search remains present and is added with the other filters as long as I do not refresh the page (3rd screenshot).

1
2
3

samifilali added a commit to ATM-Consulting/dolibarr that referenced this pull request May 13, 2024
samifilali added a commit to ATM-Consulting/dolibarr that referenced this pull request May 13, 2024
…_hidden

19.0 fix search all input hidden (backport PR Dolibarr#29557)
@eldy
Copy link
Member

eldy commented May 15, 2024

I see.
However, it seems your change will break another expected feature. If you make a global search. And just after, you try to to execute a mass action after having selected the first 2 lines for exemple. The the initial filter will be lost and the page that ask the confirmation will be different...
I see no easy way to fix this, except this way: adding a jquery onchange trigger on fields with name=search_* and when we change a value on such a field, we reset the field search_all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants