Support file-scoped namespaces in SA1516 #3513

JakubLinhart · 2022-05-22T21:44:47Z

codecov · 2022-05-23T16:05:18Z

Codecov Report

Merging #3513 (3efdceb) into master (b80f0c2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 3efdceb differs from pull request most recent head 67bd1ba. Consider uploading reports for the commit 67bd1ba to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
+ Coverage   93.26%   93.27%   +0.01%     
==========================================
  Files        1080     1081       +1     
  Lines      113982   114164     +182     
  Branches     4045     4051       +6     
==========================================
+ Hits       106303   106485     +182     
  Misses       6641     6641              
  Partials     1038     1038

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp10/LayoutRules/SA1516CSharp10UnitTests.cs

sharwell

The implementation looks fine. I'm hoping to see one test removed, one or more tests added, and some minor test simplification as noted in the specific comments.

JakubLinhart · 2022-08-03T07:26:06Z

@sharwell please, is there anything I can change or improve?

sharwell

@JakubLinhart it seems I had some comments that never got submitted. I'm clicking the submit button for them now.

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp10/LayoutRules/SA1516CSharp10UnitTests.cs

sharwell · 2022-05-25T02:08:39Z

StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/SA1516ElementsMustBeSeparatedByBlankLine.cs

+            if (members.Count > 0)
+            {
+                ReportIfThereIsNoBlankLine(context, namespaceDeclaration.Name, members[0]);
+
+                if (namespaceDeclaration.Usings.Count > 0)
+                {
+                    ReportIfThereIsNoBlankLine(context, usings[usings.Count - 1], members[0]);
+                }
+            }


❔ Is this needed, or is it duplicating work done in HandleMemberList?

While HandleMemberList checks blank lines between two consecutive members, this does the check for the namespace declaration/usings and the 1. member. This is a core part of the fix I guess 😄. Not sure how to merge it into HandleMemberList in a nice way.

ldeluigi · 2023-02-25T17:12:09Z

News? @JakubLinhart @sharwell

symbiogenesis · 2023-05-04T05:30:54Z

bump

bjornhellander · 2023-05-30T17:39:17Z

@JakubLinhart Are you interested in finishing this pull request?

bjornhellander · 2023-06-02T19:37:04Z

@sharwell, how would you like to treat this? Can someone else create a new pull request based on the work done so far?

JakubLinhart · 2023-06-15T08:13:23Z

@bjornhellander I'm still interested in finishing this PR.

bjornhellander · 2023-06-15T16:27:46Z

@JakubLinhart Excellent!

…filescopedns

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [StyleCop.Analyzers](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers) | nuget | patch | `1.2.0-beta.435` -> `1.2.0-beta.507` | --- ### Release Notes <details> <summary>DotNetAnalyzers/StyleCopAnalyzers</summary> ### [`v1.2.0-beta.507`](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.507) [Compare Source](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.435...1.2.0-beta.507) #### What's Changed - Update to StyleCop.Analyzers 1.2.0-beta.435 by [@sharwell](https://togithub.com/sharwell) in [DotNetAnalyzers/StyleCopAnalyzers#3499 - Add c# 11 test project to opencover-report.ps1 by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3506 - Use GetText instead of ToFullString by [@sharwell](https://togithub.com/sharwell) in [DotNetAnalyzers/StyleCopAnalyzers#3514 - Keep tracked nodes in a list by [@sharwell](https://togithub.com/sharwell) in [DotNetAnalyzers/StyleCopAnalyzers#3525 - Remove unnecessary nullable directives by [@sharwell](https://togithub.com/sharwell) in [DotNetAnalyzers/StyleCopAnalyzers#3530 - Remove hard-coded language versions in test projects for c# 8, 9 and 10 by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3528 - Update SA1515 to not let one range of trivia affect another by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3529 - Mentioned VS 2022 by [@twojnarowski](https://togithub.com/twojnarowski) in [DotNetAnalyzers/StyleCopAnalyzers#3549 - Remove byte order mark from schema file by [@martincostello](https://togithub.com/martincostello) in [DotNetAnalyzers/StyleCopAnalyzers#3562 - Update SA1012 to expect no space between a property pattern's opening brace and an enclosing list pattern's opening bracket by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3511 - Update Microsoft.CodeAnalysis.CSharp.Workspaces to version 4.4.0 for the c# 11 test project by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3580 - Update SA1008 to handle positional patterns inside property patterns by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3579 - Update SA1000 to trigger after keywords is, or, and, not by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3585 - Update SA1000.md by [@Youssef1313](https://togithub.com/Youssef1313) in [DotNetAnalyzers/StyleCopAnalyzers#3563 - Update SA1313 to also allow incorrect names in explicitly implemented methods from interfaces by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3569 - Update SA1023 to not trigger first in line, inside a foreach without braces by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3543 - Update SA1400 to recognize access modifier "file" by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3590 - Update SA1206 to recognize modifier "file" by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3591 - Update SA1000 to handle checked operator declarations correctly by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3505 - Update SA1402 to handle records and record structs by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3570 - Bump Newtonsoft.Json from 12.0.3 to 13.0.2 in /StyleCop.Analyzers/StyleCop.Analyzers.Status.Generator by [@dependabot](https://togithub.com/dependabot) in [DotNetAnalyzers/StyleCopAnalyzers#3584 - Update to the latest version of the testing library by [@sharwell](https://togithub.com/sharwell) in [DotNetAnalyzers/StyleCopAnalyzers#3601 - Update so that SA1600 tests will be run with the expected language version in test projects for c# 8 and above by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3614 - Update reading of file_header_template and stylecop.documentation.copyrightText to allow multiple lines by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3617 - Update SA1015 to require trailing space after an explicit generic return type in a lambda expression by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3625 - Update to Microsoft.CodeAnalysis.Analyzers 3.3.5-beta1.23205.2 by [@sharwell](https://togithub.com/sharwell) in [DotNetAnalyzers/StyleCopAnalyzers#3628 - Update SA1206 to handle c# 11 modifier "required" by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3535 - Preparations for SettingsHelper optimizations by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3635 - Correct SA1515 to not fire on the second line of a file header by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3633 - Update AnalyzersExtensions and SettingsHelper to use cached JsonValue objects where possible by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3642 - Update SA1010 to not trigger on list patterns by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3507 - Update NamingSettings and DocumentationSettings to keep one Regex instance instead of calling Regex.IsMatch by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3639 - Use ResxSourceGenerator for resource generation by [@sharwell](https://togithub.com/sharwell) in [DotNetAnalyzers/StyleCopAnalyzers#3343 - Make XmlCommentHelper faster by [@ninedan](https://togithub.com/ninedan) in [DotNetAnalyzers/StyleCopAnalyzers#3651 - Update RenameToUpperCaseCodeFixProvider to not offer a code fix if the identifier only consists of underscores by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3637 - Don't emit SA1414 for interface implementations by [@CollinAlpert](https://togithub.com/CollinAlpert) in [DotNetAnalyzers/StyleCopAnalyzers#3644 - Support file-scoped namespaces in SA1516 by [@JakubLinhart](https://togithub.com/JakubLinhart) in [DotNetAnalyzers/StyleCopAnalyzers#3513 - Update SA1137 to also consider init accessors by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3669 - Update SA1500 to also consider init accessors by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3670 - Update SA1513 to not trigger before an init accessor by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3666 - Update SA1212 to also trigger for an init accessor before a getter by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3661 - Update SA1513 codefix to use the existing newline character sequence by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3607 - Correct code fix for SA1130 when delegate expression is part of a cast expression by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3516 - Update so that c# 7 tests will be run with the expected language version in test projects for c# 8 and above by [@bjornhellander](https://togithub.com/bjornhellander) in [DotNetAnalyzers/StyleCopAnalyzers#3616 - SA1629 should allow full-sentence links instead of forcing the period to glow white by [@jnm2](https://togithub.com/jnm2) in [DotNetAnalyzers/StyleCopAnalyzers#3371 #### New Contributors - [@twojnarowski](https://togithub.com/twojnarowski) made their first contribution in [DotNetAnalyzers/StyleCopAnalyzers#3549 - [@ninedan](https://togithub.com/ninedan) made their first contribution in [DotNetAnalyzers/StyleCopAnalyzers#3651 - [@CollinAlpert](https://togithub.com/CollinAlpert) made their first contribution in [DotNetAnalyzers/StyleCopAnalyzers#3644 - [@JakubLinhart](https://togithub.com/JakubLinhart) made their first contribution in [DotNetAnalyzers/StyleCopAnalyzers#3513 **Full Changelog**: DotNetAnalyzers/StyleCopAnalyzers@1.2.0-beta.435...1.2.0-beta.507 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ThorstenSauter/NoPlan).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thorsten Sauter <Thorsten.Sauter@gmail.com>

sharwell reviewed May 23, 2022

View reviewed changes

sharwell requested changes May 23, 2022

View reviewed changes

JakubLinhart requested a review from sharwell May 24, 2022 12:33

JakubLinhart added 3 commits November 3, 2022 12:09

Add support for file scoped namespace to SA1516.

cca960a

fix style

edfbcf1

add more tests and fix extern alias

1bcb856

JakubLinhart force-pushed the fix/SA1516-filescopedns branch from 46848f0 to 1bcb856 Compare November 3, 2022 11:10

sharwell reviewed Nov 3, 2022

View reviewed changes

JakubLinhart added 5 commits June 18, 2023 09:53

Merge remote-tracking branch 'remotes/origin/master' into fix/SA1516-…

51dbe04

…filescopedns

restore changes lost in merge

c2d0129

restore more changes lost in merge

a6efbfd

review fixes 1. part

7a1ffdd

remove parentheses from constructor call

67bd1ba

JakubLinhart requested a review from sharwell June 18, 2023 11:01

sharwell approved these changes Jun 21, 2023

View reviewed changes

sharwell merged commit e2f3451 into DotNetAnalyzers:master Jun 21, 2023
4 checks passed

sharwell added this to the 1.2-beta.next milestone Jun 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support file-scoped namespaces in SA1516 #3513

Support file-scoped namespaces in SA1516 #3513

JakubLinhart commented May 22, 2022

codecov bot commented May 23, 2022 •

edited

sharwell left a comment

JakubLinhart commented Aug 3, 2022

sharwell left a comment •

edited

sharwell May 25, 2022

JakubLinhart Jun 18, 2023

ldeluigi commented Feb 25, 2023

symbiogenesis commented May 4, 2023

bjornhellander commented May 30, 2023

bjornhellander commented Jun 2, 2023

JakubLinhart commented Jun 15, 2023

bjornhellander commented Jun 15, 2023

Support file-scoped namespaces in SA1516 #3513

Support file-scoped namespaces in SA1516 #3513

Conversation

JakubLinhart commented May 22, 2022

codecov bot commented May 23, 2022 • edited

Codecov Report

sharwell left a comment

Choose a reason for hiding this comment

JakubLinhart commented Aug 3, 2022

sharwell left a comment • edited

Choose a reason for hiding this comment

sharwell May 25, 2022

Choose a reason for hiding this comment

JakubLinhart Jun 18, 2023

Choose a reason for hiding this comment

ldeluigi commented Feb 25, 2023

symbiogenesis commented May 4, 2023

bjornhellander commented May 30, 2023

bjornhellander commented Jun 2, 2023

JakubLinhart commented Jun 15, 2023

bjornhellander commented Jun 15, 2023

codecov bot commented May 23, 2022 •

edited

sharwell left a comment •

edited