Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Binance] Add adjustForTimeDifference option #544

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Herklos
Copy link
Member

@Herklos Herklos commented Aug 25, 2021

TO BE TESTED

requires Drakkar-Software/OctoBot-Trading#596

@github-actions
Copy link

Your preview environment pr-544-tentacles-drakkarsoftware has been deployed.

Preview environment endpoint is available here

@Herklos Herklos changed the base branch from master to dev August 25, 2021 08:28
@@ -29,6 +29,15 @@ class Binance(exchanges.SpotCCXTExchange):

BINANCE_MARK_PRICE = "markPrice"

BINANCE_CCXT_OPTIONS = {
"timeDifference": 0, # the difference between system clock and Binance clock
"adjustForTimeDifference": False, # controls the adjustment logic upon instantiation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this fixes the invalidNonce error, that would be amazing 🎉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants