-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce FeedScreenState to separate UI related logic, state and UI #753
base: main
Are you sure you want to change the base?
Conversation
3c2d1b9
to
2ce7e40
Compare
@@ -62,15 +57,13 @@ import io.github.droidkaigi.feeder.FeedContents | |||
import io.github.droidkaigi.feeder.FeedItem | |||
import io.github.droidkaigi.feeder.Filters | |||
import io.github.droidkaigi.feeder.Theme | |||
import io.github.droidkaigi.feeder.core.R as CoreR | |||
import io.github.droidkaigi.feeder.core.TabIndicator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spotless] reported by reviewdog 馃惗
import io.github.droidkaigi.feeder.core.TabIndicator | |
import io.github.droidkaigi.feeder.core.R as CoreR | |
import io.github.droidkaigi.feeder.core.TabIndicator |
import io.github.droidkaigi.feeder.core.util.collectInLaunchedEffect | ||
import kotlin.reflect.KClass | ||
import kotlinx.coroutines.launch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spotless] reported by reviewdog 馃惗
import kotlinx.coroutines.launch |
import kotlinx.coroutines.launch | ||
import kotlin.reflect.KClass | ||
import io.github.droidkaigi.feeder.core.R as CoreR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spotless] reported by reviewdog 馃惗
import io.github.droidkaigi.feeder.core.R as CoreR | |
import kotlinx.coroutines.launch |
} | ||
} | ||
feedScreenState.onErrorMessage(effect) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spotless] reported by reviewdog 馃惗
.map { it to rememberLazyListState() } | ||
.toMap() | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spotless] reported by reviewdog 馃惗
Issue
Overview (Required)
Links
Screenshot