-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Code like Editor in Playground and Customized Terminal #265
base: develop
Are you sure you want to change the base?
Conversation
- monaco editor by Microsoft used for VS Code - Also changed the styles of the terminal; Styled terminal scrollbar - Terminal font-family changed to "Fira Code"
- Code completion for Bhailang - Monokai theme (customized to match website)
❌ Deploy Preview for bhailang-preview failed.
|
Build fails because Next.js doesn't allow third party libraries to access global css. You would need to checkout the PR and run the server to see the changes to the docs website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new change will make the editor of bhai Lang vs code like.....waiting for quick release
@@ -0,0 +1,9 @@ | |||
# This configuration file was automatically generated by Gitpod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this file? It might cause problem with the setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the config file that Gitpod uses when you open the project in Gitpod and as as far as I have tested, doesn't meddle with the source files. Could you please elaborate on what files conflict with this one and which setup is being affected by this file? We could resolve the issue better that way.
The content of this file basically tells Gitpod to build the bundle (which is not pushed to Github, i.e. ignored) and also start the dev
server so that we can preview the docs website. If you open the project on your machine locally by checking out the PR, this file is ignored and the project should open as it does normally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with the gitpod so thought it might conflict. Anyways nice addition to the playground. Let's wait for the authorized users to react to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @ankitchouhan1020 Please merge this if this doesn't cause any issue.
@ankitchouhan1020 Please let me know what bugs/issues🐛🔨 I need to fix so that this PR gets merged soon. I'm really excited to see how the users like the new improved editor 🤩 |
Hey, Thanks for the PR. |
What does this PR do?
VS Code like Editor
Code completion
byh
==bhai ye hai
bb
==bol bhai
agb
==agar bhai
ntb
==nahi to bhai
wb
==warna bhai
jtb
==jab tak bhai
Styled Terminal
Styled the output terminal for the playground.
#374151
from TailwindCSS]What packages have been affected by this PR?
Installed packages
monaco-editor
@monaco-editor/react
Types of changes
Put an
x
in the boxes that applyBugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Package version increase in cli package?
No changes in CLI package
Checklist before merging
Put an
x
in the boxes that apply