Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6536: eliminate the instability of detachment on x86-64 platform #6579

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

onroadmuwl
Copy link
Contributor

@onroadmuwl onroadmuwl commented Jan 24, 2024

Print the done in detach_test.dll.c instead of infloop.c.
Fixes: #6536

@derekbruening
Copy link
Contributor

I re-ran the x86-64 job and the detach test still fails:

185/486 Test #185: code_api|client.detach_test ......................................***Failed  Required regular expression not found. Regex=[^starting
thank you for testing detach
thread init
detach
done
$
]  0.27 sec
CMake Error at /home/runner/work/dynamorio/dynamorio/suite/tests/runall.cmake:130 (message):
  *** kill failed (1): kill: (27149): No such process
  ***

I also took this patch and ran it locally and it fails there too in the same way.

@abhinav92003
Copy link
Contributor

I see more changes were made since Derek's last comment. When this PR is ready for a re-review, please use the Github UI to signal that (see list of reviewers on top-right side of the page).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client.detach_test failing: kill cannot find target process
3 participants