Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s.io packages to 0.26.1 and controller-runtime to 0.14.1 #1509

Merged
merged 10 commits into from
Jan 30, 2023

Conversation

chrismuellner
Copy link
Collaborator

Description

Upgrades the following dependencies:

Update unit tests using fieldSelector queries (e.g. check for metadata.name) to use fake.Client with custom index:

  • Add fake.NewClientWithIndex to automatically generate client with indexes for metadata.name for all resource kinds that currently use it
  • Replace special handling for unit tests where field selector was not respected
  • Replace MatchingFields with explicit FieldSelector so unit test with index works correctly

Other changes required for unit tests to pass:

  • Fix istio unit test by explicitly setting content type in mock server.

How can this be tested?

Unit tests pass

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly
  • I have read and understood the contribution guidelines

@chrismuellner chrismuellner added the dependencies Changes in our dependencies label Jan 27, 2023
@chrismuellner chrismuellner requested a review from a team as a code owner January 27, 2023 17:44
@0sewa0 0sewa0 merged commit c5f10e0 into main Jan 30, 2023
@0sewa0 0sewa0 deleted the feature/controller-runtime-client-fieldselector branch January 30, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes in our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants