Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node converters for handling argmax and argmin onnx operators #217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ajstarna
Copy link

@ajstarna ajstarna commented May 10, 2024

  • This PR contains the node_conversion code and tests for the ArgMax and ArgMin onnx operators (together known as arg extrema).
  • the extrema functions as provided by torch do not handle the select_last_index attribute of the onnx operators, which was added with opset_version 12.

Notes to Reviewer:

  • I added an is_cuda_available() check before running the cpu_cuda check function in the tests. Not sure if there is another way you would rather handle being able to run the tests on cpu only?
  • using pdm for development, I was only able to install the package if I modified the required python version to be >=3.8 in the pyproject.toml file. Are we sure that all dependencies work under python 3.6 or 3.7?
  • I was only able to run the tests by downgrading my onnx version from 1.16 to 1.15, or else I would get an error about supported IR version.

Thanks!

@ajstarna
Copy link
Author

Hi @ivkalgin @senysenyseny16 - Any thoughts or feedback on this? 😃 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant