Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rimraf with fs-extra/remove and fse-cli dependencies #378

Merged
merged 1 commit into from Mar 16, 2021

Conversation

nelsonni
Copy link
Member

Description:

Removes rimraf package (along with @types/rimraf) from the dependencies in Synectic. The rimraf package is redundant to the fs-extra and fse-cli packages, which build on the default Node.js FS module.

This PR resolves #304, and signifies the following version changes:

  • MAJOR version increase
  • MINOR version increase
  • PATCH version increase

Changes:

This PR makes the following changes:

Checklist:

Before submitting this PR, I have verified that my code:

  • Resides on a fix/ or feature/ branch that was initially branched off from development.
  • Passes code linting (yarn lint) and unit testing (yarn test).
  • Successfully builds a distribution package (yarn package).

Additionally, I have verified that:

  • My name is listed in the Contributors section, or this PR includes a request to add my name.
  • I have read and am aware of the CONTRIBUTING guide for this project.

@nelsonni nelsonni added feature Feature requests or improvements dependencies Issues or updates to dependency files labels Mar 16, 2021
@nelsonni nelsonni added this to the v1.0.0 milestone Mar 16, 2021
@nelsonni nelsonni merged commit c0f9457 into development Mar 16, 2021
@nelsonni nelsonni deleted the feat/remove-rimraf branch March 16, 2021 18:55
@nelsonni nelsonni linked an issue Mar 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or updates to dependency files feature Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rimraf dep and use fs.rm with recursive and force options
1 participant