Replace ea variable with a Twig function ea_context
#6209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Mar 18, 2024
| @@ -70,6 +75,7 @@ public function getGlobals(): array | |||
| $context = $this->adminContextProvider->getContext(); | |||
|
|
|||
| // when there's an admin context, make it available in all templates as a short named variable | |||
| // @deprecated | |||
There was a problem hiding this comment.
The global variable is kept for backward compatibility. It can be removed for next major release.
|
Instead of |
dunglas
approved these changes
May 5, 2024
|
Replaced by #6273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5591 (see #5591 (comment))
The Twig environment is instantiated lazily when the first template is rendered, this is why it's possible to set the global variable
eaconditionally depending on the current HTTP request. But this is fragile if there is anything that renders a template earlier.In particular, this mechanism does not work with the worker modes of FrankenPHP and RoadRunner: the Twig environment is not reinitialized between HTTP requests.
ea_contextto lazy-load theAdminContextfrom the current HTTP request. The name can be discussed.eaglobal variable is deprecated and replaced in all the templates.