New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty query term conditions #6227
Open
guillaume-sainthillier
wants to merge
3
commits into
EasyCorp:4.x
Choose a base branch
from
guillaume-sainthillier:fix-empty-queryTermConditions
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix empty query term conditions #6227
guillaume-sainthillier
wants to merge
3
commits into
EasyCorp:4.x
from
guillaume-sainthillier:fix-empty-queryTermConditions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-sainthillier
force-pushed
the
fix-empty-queryTermConditions
branch
from
April 11, 2024 16:52
a553334
to
172498d
Compare
Merged
Seb33300
approved these changes
Apr 17, 2024
@javiereguiluz This PR is the correct fix for #6223 #6242 must be reverted (it breaks postgres) and replaced by this PR. See details in #6262 |
@guillaume-sainthillier could you commit revert of #6242 in this PR? |
guillaume-sainthillier
force-pushed
the
fix-empty-queryTermConditions
branch
from
April 18, 2024 06:51
172498d
to
206966a
Compare
done |
hellomedia
referenced
this pull request
Apr 20, 2024
This PR was merged into the 4.x branch. Discussion ---------- Fixed invalid DQL Fixes #6223 When searching text having only integer fields, an invalid DQL like `SELECT entity FROM App\Entity\Product entity WHERE ` is generated because there are no any `$queryTermConditions`. This PR should fix the issue. Commits ------- 6511215 Fixed invalid DQL
guillaume-sainthillier
force-pushed
the
fix-empty-queryTermConditions
branch
from
April 29, 2024 11:30
206966a
to
4ea1c86
Compare
Seb33300
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only numeric fields are searchable,
EntityRepository::addSearchClause
generates a bugged DQL when search contains only non numeric terms.