Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow slug field to be triggered by select fields also #6282

Merged
merged 1 commit into from May 21, 2024

Conversation

Romaixn
Copy link
Contributor

@Romaixn Romaixn commented Apr 24, 2024

Currently, when targeting ChoiceField for example, the SlugField don't update, due to event listener only on keyup.

@Romaixn Romaixn changed the title feat: allow slug to be triggered by select fields also feat: allow slug field to be triggered by select fields also Apr 25, 2024
assets/js/field-slug.js Outdated Show resolved Hide resolved
@javiereguiluz javiereguiluz added this to the 4.x milestone May 21, 2024
@javiereguiluz
Copy link
Collaborator

Thanks for contributing this fix! I didn't know about this JavaScript event, so I also learned that.

@javiereguiluz javiereguiluz merged commit 0049b0d into EasyCorp:4.x May 21, 2024
10 of 11 checks passed
@Romaixn Romaixn deleted the patch-1 branch May 22, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants